DateFieldTestBase::setup() fail setting up user/permission

Just getting this in 🐛 Problem with timezone handling (caused by date_get_timezone_db returning only UTC) Needs work . Not sure why this happens.

This should work as the permission comes from date_tools, which is enabled in the modules list.

I know, but somehow it won't get recognized as valid permission. We can see in the output that the module is enabled, but right after the permission is not recognized.

setUp
fail: [Other] Line 29 of sites/all/modules/date/tests/DateFieldTestBase.test:
Enabled modules: date_all_day, date_all_day_test_feature, field, field_ui, date_api, date, date_tools

fail: [Role] Line 43 of sites/all/modules/date/tests/DateFieldTestBase.test:
Invalid permission administer date tools.

The first error means it's failing to install all of the submodules. Do you have Features downloaded locally?

The last commit proves that all the submodules are NOT enabled during the test. I haven't even tested things locally yet. Just ran into this issue on another issue and started to test things since @steinmb said tests were passing locally.

So, it seems due to "features" not being available in the filesystem, but it is required in the "date.info" file:

test_dependencies[] = features:features (2.x)

Investigating how to fix this now.

I wonder if we should list features as a dependency in the test getInfo() functions?

Lets use this issue to add the dependencies on all getInfo() functions.

The issue was that the test dependencies weren't explicitly defined and then these weren't enabled during the test, so errors were bubbling up after that.

The MR should fix the issue.

That's a good start, thank you.

I think any test that extends DateFieldTestBase needs to include "features" in its dependencies list, then others added as needed.

Do you reckon we should add these even if they are (still) not needed? Tests are green with the current additions. Happy to spread it to other tests but wanted to ask first.

I think it's worth doing for completeness sake, in the UI it then won't let you run the sub tests.

Could also refactor it so that getInfo() is defined in DateFieldTestBase with the main dependencies and then the name and description are overridden in the sub classes.

Working on an update.

All getInfo() methods now have a dependencies list.

Committed. Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.