- 🇺🇸United States rhovland Oregon
Development on this fork is active suggest switching dependencies to it. Have uploaded a patch that should switch to the new repo and a php8.0 compatible version as the minimum requirement.
- Status changed to Needs review
almost 2 years ago 12:09am 26 January 2023 -
jsacksick →
committed 59d4cd8d on 8.x-1.x authored by
rhovland →
Issue #3248338 by rhovland, jsacksick: Dependency vinceg/usps-php-api is...
-
jsacksick →
committed 59d4cd8d on 8.x-1.x authored by
rhovland →
- Status changed to Fixed
over 1 year ago 4:49am 3 March 2023 - 🇮🇱Israel jsacksick
Committed, now requiring the 2.0 version which requires PHP 8.1.
- Status changed to Needs work
over 1 year ago 7:42am 3 March 2023 - 🇮🇱Israel jsacksick
Unfortunately... The 2.0 version has a bug... Just opened an issue in that repo... But we may have to fork it in the meantime if we want to tag a new release soon...
- 🇺🇸United States bobburns
A composer update brought down the latest dev version and genyaa usps api - which promptly broke the USPS shipping
Apparently the namespace USPS does not point to genyaa and still points to vinceg
If I rename the vinceg directory to _vinceg to hold it off elsewhere and then rename the /vendor/genyaa directory to /vendor/vinceg it works
Otherwise I am greeted with this error below
The website encountered an unexpected error. Please try again later.
Error: Class "USPS\Enum\ServiceType" not found in Drupal\commerce_usps\USPSShipment->setService() (line 79 of modules/commerce_usps/src/USPSShipment.php).
Drupal\commerce_usps\USPSShipment->setService() (Line: 25)
Drupal\commerce_usps\USPSShipment->buildPackage(Object) (Line: 68)
Drupal\commerce_usps\USPSShipmentBase->getPackage(Object) (Line: 164)
Drupal\commerce_usps\USPSRateRequestBase->getPackages() (Line: 136)
Drupal\commerce_usps\USPSRateRequest->buildRate() (Line: 77)
Drupal\commerce_usps\USPSRateRequestBase->getRates(Object, Object) (Line: 92)
Drupal\commerce_usps\Plugin\Commerce\ShippingMethod\USPS->calculateRates(Object) (Line: 89)
Drupal\commerce_shipping\ShipmentManager->calculateRates(Object) (Line: 100)
Drupal\commerce_shipping\Plugin\Field\FieldWidget\ShippingRateWidget->formElement(Object, 0, Array, Array, Object) (Line: 353)
Drupal\Core\Field\WidgetBase->formSingleElement(Object, 0, Array, Array, Object) (Line: 220)
Drupal\Core\Field\WidgetBase->formMultipleElements(Object, Array, Object) (Line: 111)
Drupal\Core\Field\WidgetBase->form(Object, Array, Object) (Line: 183)
Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object, Array, Object) (Line: 335)
Drupal\commerce_shipping\Plugin\Commerce\CheckoutPane\ShippingInformation->buildPaneForm(Array, Object, Array) (Line: 546)
Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->buildForm(Array, Object, 'order_information')
call_user_func_array(Array, Array) (Line: 534)
Drupal\Core\Form\FormBuilder->retrieveForm('commerce_checkout_flow_multistep_default', Object) (Line: 281)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 222)
Drupal\Core\Form\FormBuilder->getForm(Object, 'order_information') (Line: 143)
Drupal\commerce_checkout\Controller\CheckoutController->formPage(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19) - 🇮🇱Israel jsacksick
@bobburns: Don't update just yet, better to wait for a release... The library is currently broken.
- 🇺🇸United States bobburns
@jsacksick it is working fine - what part of the genyaa library is broken? It brings in quotes - obviously using curl - since I DID NOT patch for the http_build_query patch in 9.5.4, so the vinceg libray is not being called
- 🇮🇱Israel jsacksick
The tests are failing (See https://www.drupal.org/pift-ci-job/2608502 → ). Opened a PR that fixes the issue uncovered by the tests but so far the maintainer hasn't replied.
See
https://github.com/GeNyaa/USPS-php-api/pull/7/filesI'd prefer to avoid creating yet another fork to maintain, so waiting a bit more.
-
jsacksick →
committed 4c4ab784 on 8.x-1.x
Issue #3248338 followup by jsacksick: Require the latest version of the...
-
jsacksick →
committed 4c4ab784 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 6:59pm 8 March 2023 - 🇮🇱Israel jsacksick
The PR was merged, went ahead and tagged a new Commerce USPS release.
- 🇺🇸United States kevinhbruce Maryland
Hello! I'm having the same problem that boburns with the error 'Error: Class "USPS\Enum\ServiceType" not found in...' I'm updated to the latest (8.x-1.6), but it's referencing a namespace that doesn't exist with this install-"USPS\Enum\ServiceType" on lines 79 and 87 of src/USPSShipment.php. Am I missing something? Where can I find the class USPS\Enum\ServiceType?
- 🇮🇱Israel jsacksick
Hello! How did you update the module? Did you use composer?
The class is here: https://github.com/GeNyaa/USPS-php-api/blob/v2.x/src/Enum/ServiceType.php.
Automatically closed - issue fixed for 2 weeks with no activity.