- 🇺🇦Ukraine podarok Ukraine
git apply inline_entity_form-auto_open_edit_mode-3247446-3.patch error: patch failed: config/schema/inline_entity_form.schema.yml:72 error: config/schema/inline_entity_form.schema.yml: patch does not apply error: patch failed: src/Plugin/Field/FieldWidget/InlineEntityFormComplex.php:105 error: src/Plugin/Field/FieldWidget/InlineEntityFormComplex.php: patch does not apply
- Assigned to bharath-kondeti
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:15am 12 May 2023 - 🇮🇳India bharath-kondeti Hyderabad
Patch re-rolled against 2.0.x branch. Please review
-
podarok →
committed 11845164 on 2.0.x authored by
bharath-kondeti →
Issue #3247446 by filsterjisah, bharath-kondeti, Anybody: Auto-open...
-
podarok →
committed 11845164 on 2.0.x authored by
bharath-kondeti →
- Status changed to Fixed
over 1 year ago 9:44am 13 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Needs review
about 1 year ago 6:55pm 9 December 2023 - Status changed to Needs work
about 1 year ago 6:56pm 9 December 2023 - 🇩🇪Germany geek-merlin Freiburg, Germany
As the issue tag states, this needs tests to be committed.
- 🇬🇧United Kingdom jonathanshaw Stroud, UK
The approach proposed here does not handle well the situation of nested IEFs, when Cancel is pressed on the parent IEF. This is because of inline_entity_form_close_all_forms() I think, that function seems to override what this patch does.
- 🇩🇪Germany geek-merlin Freiburg, Germany
@jonathanshaw
I don't grok it fully but maybe you can describe the exact steps that uncover the problem you describe, the chances that your objection gets into the tests drastically increase. - 🇬🇧United Kingdom jonathanshaw Stroud, UK
Re #20 from memory:
1. Sitebuilder: Nest once complex IEF inside another
2. Sitebuilder: Set the inner one to auto open
3. User: Open an entity in the outer IEF; SUCCESS the inner IEF auto opens properly.
4. User: Cancel the opened outer IEF
5. User Open the same entity again in the outer IEF; FAILURE the inner IEF does not auto open now! - 🇺🇸United States dcam
I closed ✨ Expand inline entity form widget setting Closed: duplicate as a duplicate. I'm granting credit to @vyasamit2007 and @rhovland for work done on a patch in that issue. But the patch was fairly similar. I don't know that there's anything that would be useful from it.
Everyone please remember to check for existing issues before opening a new one. Today I've closed two issues that were older than this one.