- 🇺🇸United States firewaller
The patch on #3037259 fixed an issue with infinite redirects because of a trailing question mark (?).
I enabled "Enforce clean and canonical URLs." and all of a sudden, I got infinite redirect loop when visiting the page. It happens because $original_uri and $redirect_uri never match here:
if ($redirect_uri != $original_uri) {
$response = new TrustedRedirectResponse($redirect_uri, $this->config->get('default_status_code'));
$response->headers->set('X-Drupal-Route-Normalizer', 1);
$event->setResponse($response);
}
I the problem is in the $original_uri, which is retrieved from request object and REQUEST_URI global variable at the end. I'm not sure why, but it returns URI with a trailing slash. Before the check, I have something like:
$redirect_uri: my.site/fr
$original_uri: my.site/fr/
I experienced the same issue in my local and Acquia environments.
My setup:
Drupal core: 9.2.6;
Redirect: 8.x-1.6;
2 languages with URL (prefix) detection;
Enabled "Enforce clean and canonical URLs" option of Redirect module;
There might be duplicates of this issue, but I was a bit lost in the issue queue.
Looking at
#2932615: Don't allow adding source paths with trailing slashes, they won't ever work →
I think the most obvious solution seems to strip the trailing slash from $original_uri, but I'm not sure what the consequences might be.
Review
Commit
Active
1.6
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
The patch on #3037259 fixed an issue with infinite redirects because of a trailing question mark (?).