- Merge request !20#3244351 Prevented override of a node title via other hooks, fixed tests β (Open) created by quadrexdev
- Status changed to Needs review
7 months ago 5:06pm 5 April 2024 - πΊπ¦Ukraine quadrexdev Lutsk
I think we don't need to test the revision revert/revision delete forms In testRevisionsPage(), just because on these forms there is no node title by default.
For reference - https://git.drupalcode.org/project/drupal/-/blob/8.8.x/core/modules/node....And this - https://git.drupalcode.org/project/drupal/-/blob/8.8.x/core/modules/node...
But, it was there because of this line:
$title = \Drupal::service('html_title.filter')->decodeToMarkup($node->label());
in html_title_preprocess_page_title. That's why the testRevisionsPage() was passed before the changes within this issue.Prepared all the changes in the pull request - https://git.drupalcode.org/project/html_title/-/merge_requests/20.
Please review