- Merge request !20#3244351 Prevented override of a node title via other hooks, fixed tests → (Open) created by quadrexdev
- Status changed to Needs review
over 1 year ago 5:06pm 5 April 2024 - 🇺🇦Ukraine quadrexdev Lutsk
I think we don't need to test the revision revert/revision delete forms In testRevisionsPage(), just because on these forms there is no node title by default.
For reference - https://git.drupalcode.org/project/drupal/-/blob/8.8.x/core/modules/node....And this - https://git.drupalcode.org/project/drupal/-/blob/8.8.x/core/modules/node...
But, it was there because of this line:
$title = \Drupal::service('html_title.filter')->decodeToMarkup($node->label());in html_title_preprocess_page_title. That's why the testRevisionsPage() was passed before the changes within this issue.Prepared all the changes in the pull request - https://git.drupalcode.org/project/html_title/-/merge_requests/20.
Please review
- Status changed to RTBC
9 months ago 3:37pm 10 December 2024 - 🇨🇦Canada JayDarnell Guelph, Ontario
I was optimistic when I found this issue and an attached patch that was merged but this doesn't seem to fix the problem for me. I have a custom module that is attempting to alter the page title for the route entity.node.edit_form based on a field value on the node. Basically we have a content type that is being used in two contexts and we want to present that content type with a different label based on a field value. So instead of saying "Edit Article" if a field value is set to a certain value I want it to say "Edit Notice". My custom module updates the title just fine, but then html_title completely ignores my changes by reseting the page title from scratch.
I understand the goal here is to be able to supply other tags as part of title fields and maintain them, but if edits to other portions of the node edit page title are needed I'm not sure how to accomplish that alongside this module.