- ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- Status changed to RTBC
about 1 year ago 11:38am 30 April 2024 - ๐ฎ๐ณIndia dev16.addweb
I have tested this patch and raised MR for the same.
- Status changed to Needs work
9 months ago 3:16pm 24 July 2024 - ๐ช๐ธSpain marcoscano Barcelona, Spain
@silvi.addweb thanks for trying to help, but opening a MR with the same changes of the patch, when in the previous comment I mentioned what was missing in the patch, isn't enough to move this to RTBC
- ๐ง๐ชBelgium fernly
Rerolled existing patch code against current 8.x-2.x-dev, based on 2.0.0-beta16.
- ๐บ๐ธUnited States Bao Truong
Thanks fernly for rerolling this patch against the current dev branch. This was exactly was I was looking for. Applied your patch #8 and it works great!
- ๐ฌ๐งUnited Kingdom james.williams
james.williams โ made their first commit to this issueโs fork.
- ๐ฌ๐งUnited Kingdom james.williams
james.williams โ changed the visibility of the branch 8.x-2.x-issue-3244334 to hidden.
- ๐ฌ๐งUnited Kingdom james.williams
Updated MR to account for entities without bundles, and those that use a bundle key other than 'type'.
P.S. The MR uses a branch named 8.x-2.x, which is a bit awkward for when the canonical repo makes updates to the branch of that name! Never mind; I've merged the changes from the original repo's branch into this issue fork's one.
- ๐ฌ๐งUnited Kingdom james.williams
(Tests all pass, having updated them to account for this, since they already assert the contents of the column that would now include the bundle text. Those existing assertions mean new tests would be unnecessary, I believe.)
- ๐ช๐ธSpain marcoscano Barcelona, Spain
Thanks for working on this.
Technically, we still need to test that in a bundle-less entity type, nothing breaks and the text displayed is what we expect.
Also, since we are here... can we please update the bundle label in the test module to be different than the bundle id? This way we also test that we are displaying on the UI the label, and not the ID. -
marcoscano โ
committed c033c8bd on 8.x-2.x authored by
silvi.addweb โ
Issue #3244334 by james.williams, flyke, fernly, marcoscano: Usage: show...
-
marcoscano โ
committed c033c8bd on 8.x-2.x authored by
silvi.addweb โ
- ๐ช๐ธSpain marcoscano Barcelona, Spain
Excellent, thanks for contributing!
Automatically closed - issue fixed for 2 weeks with no activity.