- First commit to issue fork.
- @sunlix opened merge request.
- 🇩🇪Germany sunlix Wesel
Hey,
I have normalized the widget array shape for the
taget_id
key.
Additionally I have added a condition on the widget type, becaue theselect
widget needs only the entity ID as a field value.
Theentity_autocomplete
widget needs the full entity object for the#default_value
.Adjusted the tests to cover that change, too.
- Status changed to Needs review
over 2 years ago 3:06pm 23 March 2023 - Status changed to Needs work
over 2 years ago 6:11am 30 March 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks @sunlix - looks good, I would like to keep the (broken) nested target_id if possible, just to minimize the chance of breaking people's existing form alters.
- Status changed to Needs review
over 2 years ago 10:27pm 30 March 2023 - 🇩🇪Germany sunlix Wesel
So that should work. Test are running again. Touched fewer code.
Hopefully you agree now :) I am sorry I was tired and confused by some test failures.
At some point there was no really brain power involved :D good night :) - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Hopefully you agree now :) I am sorry I was tired and confused by some test failures.
No need to apologize! thanks for your contribution.
I'll create a new release shortly
- Status changed to Fixed
over 2 years ago 11:27pm 30 March 2023 -
larowlan →
committed f44546e1 on 3.x authored by
sunlix →
Issue #3242501 by sunlix, larowlan, dat deaf drupaler, vermario: Enable...
-
larowlan →
committed f44546e1 on 3.x authored by
sunlix →
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Automatically closed - issue fixed for 2 weeks with no activity.