- last update
over 1 year ago 199 pass - last update
over 1 year ago 196 pass, 1 fail
Working on #3233375: Stop supporting Xml in queries → I discovered an unrelated bug...
In #3102407: Support partial updates to Xero items → we introduced the notion that Xero items could have "specified properties" which indicated a non-default value that had been set on an item and should be pushed to Xero. Part of that process is that read-only properties are dropped from the values output when XeroItemBase::getValue() is called.
Unfortunately, we forgot to allow for deserialization. Deserialization involves calling getValue on an item in order to add it to the list: $items->offsetSet(NULL, $item->getValue());.
The code as it currently is makes it impossible to deserialize a read-only property provided by Xero.
Try deserializing a user response (all user properties are read-only).
Use not pristine state to do custom getValue for specified properties.
None.
Denormalized items and lists are always pristine.
None.
Needs review
2.0
Code
The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.