- First commit to issue fork.
- @eojthebrave opened merge request.
- 🇺🇸United States eojthebrave Minneapolis, MN
It looks like much of this issue was fixed in 📌 Port support for recurly.Pricing() from D7 to D8 Fixed . Mainly injecting the Recurly client object into the \Recurly_Billing calls. I opened a new MR to fix the one remaining issue with \Recurly_Billing (it was just easier to start a new one than to try and rebase the old one). And incorporated the fixes from above. I also added tests for the billing info update form to hopefully help ensure we don't have this issue again.
In adding tests I also cleaned up a few other things:
- Remove dependency on the deprecated jQuery.once library
- Fix the code that pre-populates the billing info update form with data from Recurly, it was there but not working because the data structure from Recurly didn't match that of the form
- Add tests
- Status changed to RTBC
almost 2 years ago 2:39pm 24 January 2023 - 🇺🇸United States blakehall
After a review, this looks good to me. Marking RTBC
-
eojthebrave →
committed 3e24ff96 on 4.x
Issue #3241695 by eojthebrave, sultancillo, j_ten_man, loze, rakesh....
-
eojthebrave →
committed 3e24ff96 on 4.x
- Status changed to Fixed
almost 2 years ago 3:13pm 24 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.