Limit Html filters were silently switched to PHP by 2.1.0 update causing "The PHP filter has been deprecated" notices

Created on 23 September 2021, almost 3 years ago
Updated 10 August 2023, 11 months ago

Problem/Motivation

Since I updated the module to version 2.1.1, I get the following message on every page: The PHP filter has been deprecated. Please use the "Limit allowed HTML tags" filter instead.

I have never used the PHP filter, and I have already re-exported the configuration - unfortunately it does nothing. What else can I do? Thanks in advance for the help.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

🇩🇪Germany zcht

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇩🇪Germany zcht

    version 3.0.0-rc1 has been released in the meantime, but it still contains this critical major bug. this should definitely be fixed before the new version gets a stable tag.

  • 🇺🇸United States angrytoast Princeton, NJ

    Agree with the assessment in #5 and #8. Here's a starter patch against 3.0.x that addresses those points:

    • Deprecation message is only shown on the formatter summary
    • Warnings are logged, not shown as a message on viewing the formatter
    • Add hook_requirements warning on the status page if deprecated instances are detected
    • Add update hook to update the affected configs. I just picked 8001 as the number since the latest info.yml claims 8.x compatibility and there has never been an install file for this module

    This patch addresses core.entity_view_display and views.view config as the obvious spots where there may be affected field formatters. Not sure of other potential cases.

  • Status changed to Needs review 12 months ago
  • 🇺🇸United States angrytoast Princeton, NJ
  • 🇺🇸United States angrytoast Princeton, NJ

    Whoops, missed a spot in the patch. Here's the updated one.

  • 🇮🇳India anand.toshniwal93
    1. Updated static queries to dynamic queries
    2. Fixed issue with batch processing

    Patch re-rolled against 3.0.0-rc1 and with above updates.

  • 🇮🇳India anand.toshniwal93

    Mistakenly added orderBy to query removed it in this patch.

  • 🇮🇳India anand.toshniwal93

    Fixed update hook number for previous patch (><)

Production build 0.69.0 2024