social_auth_strava project open to new maintainer applications on 30 Sep, 2021

Hi,

I'm going to use this project for big project soon and noticed that it's not production ready. I would like to take care of this module and pick up a maintainer role. I've security coverage opt-in permission and can provide stable releases for Drupal 9 and 10.

Dear nginex, that would be awesome!

I added you as a maintainer, if I can be of any help (for example testing).

Feel free to contact me.

Thanks a lot in advance!

Thank you so much, will do my best

Hello nginex,

I just checked the existing module and API to have an idea of the changes that will be needed to make the module work again.

When investigating this I noticed the following notification:

"January 15, 2019
Email address is no longer part of the profile:read_all scope and is removed from the athlete model."

I also checked the API documentation and it looks like Strava does not return an e-mailaddress anymore. When you would authorize there is no way of checking/matching the e-mail with existing users. So you wouldn't know if you need to login an existing user or create a new user.

This is something to look into before putting effort in this module as I don't think it's possible anymore.

I look forward to your feedback.

Hey, you are right, email is no longer available, but I think it's not a problem if we store athlete id for the user, so we can check if there is a user with specific athlete id, if so login that user, otherwise create a new user with the id. Anyway, user email field is optional in Drupal

Hey nginex,

If it is a new platform with no users that will work.

If you have an existing platform with users in it already and all of a sudden they start using the Social Strava button login instead of their emailaddress this will create a new account instead of logging in their existing account (no match on email address) so I do think this will have an impact.

Good luck!

Thank you, @f0ns

I will take this into account

Automatically closed - issue fixed for 2 weeks with no activity.

Finally got some time for contribution. Here we go https://www.drupal.org/project/social_auth_strava/releases/2.0.0 →

Thank you!

I've updated the module page as it was still talking about the email address.

https://www.drupal.org/project/social_auth_strava →