Module is not D9 compatible yet

Created on 13 September 2021, over 3 years ago
Updated 14 March 2023, almost 2 years ago

Problem/Motivation

During our D9 compatibility checks with upgrade_status report, we see that the amazon_onsite module is not D9 ready yet.

Report output from PHPStan analyse

phpstan analyse --memory-limit 512M docroot/modules/contrib/amazon_onsite/
Note: Using configuration file /var/www/html/phpstan.neon.
 21/21 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------------------------------- 
  Line   src/Controller/AopItemController.php                                                               
 ------ --------------------------------------------------------------------------------------------------- 
  79     Call to an undefined method Drupal\Core\Entity\EntityInterface::getRevisionCreationTime().         
  107    Call to an undefined method Drupal\Core\Entity\EntityStorageInterface::revisionIds().              
  116    Call to an undefined method Drupal\amazon_onsite\AopFeedItemInterface::getRevisionUser().          
  120    Call to an undefined method Drupal\amazon_onsite\AopFeedItemInterface::getRevisionCreationTime().  
  122    Call to deprecated method l() of class Drupal\Core\Controller\ControllerBase:                      
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use                                              
           \Drupal\Core\Link::fromTextAndUrl() instead.                                                     
  128    Call to deprecated method link() of class Drupal\Core\Entity\EntityInterface:                      
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                                  
           Use \Drupal\Core\EntityInterface::toLink()->toString() instead.                                  
  140    Call to an undefined method Drupal\amazon_onsite\AopFeedItemInterface::getRevisionLogMessage().    
 ------ --------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Controller/RssController.php                                                   
 ------ ----------------------------------------------------------------------------------- 
  128    Call to an undefined method Drupal\Core\Entity\EntityInterface::getChangedTime().  
  174    Call to an undefined method Drupal\Core\Entity\EntityInterface::getTitle().        
  177    Call to an undefined method Drupal\Core\Entity\EntityInterface::getChangedTime().  
 ------ ----------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   src/Form/AopFeedItemForm.php                                                                                 
 ------ ------------------------------------------------------------------------------------------------------------- 
  34     Method Drupal\amazon_onsite\Form\AopFeedItemForm::save() should return int but return statement is missing.  
 ------ ------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------- 
  Line   src/Form/AopItemForm.php                                                                                 
 ------ --------------------------------------------------------------------------------------------------------- 
  38     PHPDoc tag @var for variable $entity contains unknown class Drupal\amazon_onsite\Entity\AopItem.         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                       
  38     Variable $entity in PHPDoc tag @var does not match assigned variable $form.                              
  84     Method Drupal\amazon_onsite\Form\AopItemForm::save() should return int but return statement is missing.  
 ------ --------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Form/AopItemRevisionDeleteForm.php                                                                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 
  22     Property Drupal\amazon_onsite\Form\AopItemRevisionDeleteForm::$revision has unknown class Drupal\amazon_onsite\Entity\AopItemInterface as its type.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  60     Call to deprecated function format_date():                                                                                                           
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                                                                                    
           Use \Drupal::service('date.formatter')->format().                                                                                                  
  60     Call to method getRevisionCreationTime() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                           
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  68     Call to method id() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  92     Call to method getRevisionId() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  95     Call to method label() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  96     Call to method getRevisionId() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  99     Call to deprecated function format_date():                                                                                                           
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                                                                                    
           Use \Drupal::service('date.formatter')->format().                                                                                                  
  99     Call to method getRevisionCreationTime() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                           
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  100    Call to method label() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  104    Call to method id() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  106    Call to method id() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
  109    Call to method id() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                   
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Form/AopItemRevisionRevertForm.php                                                                                                                                                
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  23     Property Drupal\amazon_onsite\Form\AopItemRevisionRevertForm::$revision has unknown class Drupal\amazon_onsite\Entity\AopItemInterface as its type.                                   
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  61     Call to method getRevisionCreationTime() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                            
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  69     Call to method id() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  83     Method Drupal\amazon_onsite\Form\AopItemRevisionRevertForm::getDescription() should return Drupal\Core\StringTranslation\TranslatableMarkup but returns string.                       
  102    Call to method getRevisionCreationTime() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                            
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  105    Access to property $revision_log on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                    
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  105    Access to property $revision_log on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                    
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  108    Call to method save() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                               
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  111    Call to method label() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                              
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  112    Call to method getRevisionId() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                      
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  115    Call to method label() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                              
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  120    Call to method id() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                                 
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  135    Parameter $revision of method Drupal\amazon_onsite\Form\AopItemRevisionRevertForm::prepareRevertedRevision() has invalid typehint type Drupal\amazon_onsite\Entity\AopItemInterface.  
  135    Parameter $revision of method Drupal\amazon_onsite\Form\AopItemRevisionRevertForm::prepareRevertedRevision() has invalid typehint type Drupal\amazon_onsite\Entity\AopItemInterface.  
  135    Return typehint of method Drupal\amazon_onsite\Form\AopItemRevisionRevertForm::prepareRevertedRevision() has invalid type Drupal\amazon_onsite\Entity\AopItemInterface.               
  136    Call to method setNewRevision() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  137    Call to method isDefaultRevision() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                                  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
  138    Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0 and is removed from drupal:10.0.0. Use \Drupal::time()->getRequestTime();                                        
  138    Call to method setRevisionCreationTime() on an unknown class Drupal\amazon_onsite\Entity\AopItemInterface.                                                                            
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                                                                                    
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------- 
  Line   src/Form/SettingsForm.php                                           
 ------ -------------------------------------------------------------------- 
  204    Call to deprecated function file_default_scheme():                  
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use               
           \Drupal::config('system.file')->get('default_scheme') instead.    
  208    Caught class Drupal\amazon_onsite\Form\FileException not found.     
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ -------------------------------------------------------------------- 

 ------ ----------------------------------------------------------- 
  Line   src/Plugin/Field/FieldType/AopProductItem.php              
 ------ ----------------------------------------------------------- 
  130    Function random_int invoked with 1 parameter, 2 required.  
 ------ ----------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/AopProductWidget.php                                                              
 ------ --------------------------------------------------------------------------------------------------------------- 
  67     Access to an undefined property Symfony\Component\Validator\ConstraintViolationInterface::$arrayPropertyPath.  
 ------ --------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 50 errors

Steps to reproduce

Proposed resolution

  • Fix D9 deprecation issues.
  • Fix D10 deprecation issue.
  • Fix issues from PHPStan analyse.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany IT-Cru Munich

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024