- First commit to issue fork.
- Assigned to lrwebks
- Status changed to Needs work
8 months ago 11:05am 3 June 2024 - π©πͺGermany lrwebks Porta Westfalica
I'll be starting to work on this issue now!
- Status changed to Needs review
8 months ago 12:11pm 3 June 2024 - Status changed to Needs work
8 months ago 1:04pm 3 June 2024 - π©πͺGermany Anybody Porta Westfalica
Nice work @LRWebks you can remove the "Draft" prefix. I think it should only be used, if the changes are more or less experimental / unclear. Otherwise it prevents tests from running.
Code looks good to me. Perhaps you could add an "Internal" prefix to the "Notes" label => "Internal notes" to clarify that these aren't shown anywhere.
Could we also have a simple addition to tests to ensure it is saved as expected?
Then this LGTM and is ready for final review :)
Nice addition for daily work, I would have needed this several times already. - last update
8 months ago 8 pass - Status changed to Needs review
8 months ago 2:14pm 4 June 2024 - Status changed to Needs work
8 months ago 2:15pm 4 June 2024 - π©πͺGermany lrwebks Porta Westfalica
I'll be implementing your proposed changes quickly.
- last update
8 months ago 8 pass - Status changed to Needs review
8 months ago 2:32pm 4 June 2024 - π©πͺGermany lrwebks Porta Westfalica
Done! Surely, a test of the Form Save behavior for the notes would be necessary, however this test does not exist in this code version but is being implemented in β¨ Add "status" option to allow enabling / disabling snippets Needs work , so it's the same thing as with the unrelated change from before. We just shouldn't forget about this once both issues are merged!
- Issue was unassigned.
- Status changed to RTBC
8 months ago 3:14pm 4 June 2024 - π©πͺGermany Anybody Porta Westfalica
Thanks @LRWebks! LGTM!
So settings this RTBC, but whoever merges the other issue should please then set this NW to implement the tests here finally. Once it goes green, this can be set RTBC again and be merged! :)
β¨ Add "status" option to allow enabling / disabling snippets Needs work
- Status changed to Closed: won't fix
7 months ago 6:44pm 25 June 2024 - πΊπΈUnited States pookmish
I feel like this is an unnecessary bloat to the already complex form. And comments can often be placed directly in the JS/CSS asset. If there is a desire for notes field, it would be straight forward to modify the entity type to add the field.
- π©πͺGermany Anybody Porta Westfalica
Thanks for the feedback @pookmish. I'm a bit disappointed to no see this merged, because we had many cases where that description would have helped our team and our clients a lot.
Of course, you can use the workaround to put the comments into code or write a custom module, but we ran into this in different projects, so I'd see this as a generally helpful feature. We can definitely make it less visible if that helps.
In our case, it's often additional information for the site builders / administrator that needs to be placed besides the technical script. For example, what it is used for, in which areas, which GDPR terms apply here etc.
Of course, I accept, if you still decline the feature.