PHP Deprecated: Required parameter $grantUpdate follows optional parameter $langcode

As Chris--S said it's better to just add the defaults to the args after langcode.
I've created a branch with just that fix which should be uncontroversial to apply.

In the meantime apply a patch from https://git.drupalcode.org/issue/permissions_by_term-3231556/-/commit/42...

E.g. in composer.json under extras patches insert:

"drupal/permissions_by_term": {
  "Fix optional parameters patch": "https://git.drupalcode.org/issue/permissions_by_term-3231556/-/commit/421de6c96e79e25225a04aa2ab4043245b61fc01.diff"
}

Getting the same error above with 3.1.21, patches from #4 and #14 aren't applying. This happens when first selecting an Allowed Role for the term. After selecting the Allowed Role then the error doesn't show if editing and saving the term again.

Then whenever selecting a term for access on a node and saving, the below happens every time edit and save.

Deprecated function: Optional parameter $langcode declared before required parameter $grantDelete is implicitly treated as a required parameter in include() (line 571 of C:\xampp\htdocs\vendor\composer\ClassLoader.php).

@crutch my patch (#14) is based on 3.1.21. If all else (composer?) fails just change that one line by hand (insert = 0 two times).

https://git.drupalcode.org/issue/permissions_by_term-3231556/-/commit/42...

Yes that works, thank you zany!

It's not clear what patch is up for review/committal here any more, so this can't really be put forward as RTBC. Are we talking about the one at #4 (which was the one set to RTBC) or the subsequent branch at https://git.drupalcode.org/issue/permissions_by_term-3231556/-/commit/42... (which doesn't have an associated MR)?

I can confirm that #4 works with Permissions By Term version 3.1.22 with Drupal 10.0.9.

I applied patch #4 on Drupal 9.5.10 and receive the following error when editing a node:

Uncaught PHP Exception Twig\Error\LoaderError: "Template "__TwigTemplate_64fc0bdf00e158aebd00147ec16b6001" is not defined." at /mnt/www/html/oitdingobks7p7fmgh/vendor/twig/twig/src/Loader/ChainLoader.php line 98 request_id="v-4db60c12-3559-11ee-a1ac-0ee5c75963b7"

@joelseguin @protitude the patch #14 is recommended and proposed, it does not change the calling parameters.

Thanks @zany. I applied #14 and that worked as well.

I have just updated the issue fork against the main dev branch and created a MR.

Thanks for the MR. Created an new patch release with it (3.1.23): https://www.drupal.org/project/permissions_by_term/releases/3.1.23 →

Automatically closed - issue fixed for 2 weeks with no activity.

Jeya sundhar → made their first commit to this issue’s fork.