- π·πΈSerbia holo96
I guess we will need tests for this
Maybe even to update existing onesBut let's first do maual testing.
PS. Roles are also updated at least in drupal 10 where I tested this.
- Status changed to Needs review
over 1 year ago 12:31pm 22 May 2023 - Open on Drupal.org βEnvironment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs work
over 1 year ago 3:26pm 24 May 2023 - π¨πSwitzerland bircher π¨πΏ
The patch in 8 is a good start, but it is far from complete. It currently does the removing only. It also needs to put the removed config back in a "patch" way, otherwise on an import the removed things will not be added again. I think it would be best to start with a test here.
The test would have a config which changes when a module is excluded. (such as a role having the permission removed)
The test should assert that the permission is not present in the exported config, but when importing the config again the permission should be set again. At the very least. There are other cases we should test too but this would be a good start. - πΊπΈUnited States seanr
I can confirm patch in #8 only partially fixes it. It's a damned good thing I watch those config diffs like a hawk. π€£ FWIW, I'm now using https://www.drupal.org/project/config_ignore β and I recommend that anyway as it's targeted to specific configs rather than the whole module.