- ๐ฆ๐บAustralia elc
This does delete the DB delete query code (plus all other code related the DB stored config), but it does not replace the functionality by actually deleting the config for the now deleted role. It just gets the value and does nothing with it.
- Status changed to Needs review
about 1 year ago 1:57am 23 October 2023 - ๐ฆ๐บAustralia elc
Updated patch to also remove the now defunct config entry.
There's no schema for the config on this module.
- Status changed to RTBC
about 1 year ago 2:17am 23 October 2023 - ๐ฆ๐บAustralia elc
My change was so small that I'm going to mark this as RTBC too.
Schema is addressed in ๐ Missing config schema & fix weight spelling RTBC .
- Status changed to Needs work
9 months ago 3:54pm 4 April 2024 - ๐ฉ๐ชGermany Anybody Porta Westfalica
@ELC could you please create a MR and rebase this on 10.x now that ๐ Missing config schema & fix weight spelling RTBC is merged?
- ๐ฌ๐งUnited Kingdom aaron.ferris
aaron.ferris โ made their first commit to this issueโs fork.
- ๐ฌ๐งUnited Kingdom aaron.ferris
aaron.ferris โ changed the visibility of the branch 3226405-userrole-delete to hidden.
- Merge request !6Issue #3226405: remove redundant functions and clear rid via config โ (Closed) created by aaron.ferris
- ๐ฌ๐งUnited Kingdom aaron.ferris
Patch didn't apply cleanly for me off 10.x, but ive raised a MR with what looks like the main purpose of the patch
- Delete db query functions (they look redundant anyway)
- Clear role related config in
front_page_user_role_delete
- Status changed to Needs review
9 months ago 4:32pm 4 April 2024 - Status changed to RTBC
9 months ago 1:54am 5 April 2024 - ๐ฆ๐บAustralia elc
MR contains everything that was in the patch. Thank you @aaron.ferris
All of the database related queries were redundant code now that settings for the module are kept in config instead. The code in hook_user_role_delete() is the only part that hadn't been replaced resulting in dangling config items.
- Status changed to Fixed
9 months ago 7:54am 5 April 2024 - ๐ฉ๐ชGermany Anybody Porta Westfalica
Fixed in 10.x (part of another commit).
Automatically closed - issue fixed for 2 weeks with no activity.