ui-dialog-titlebar-close button not showing up in modals

Created on 22 July 2021, over 4 years ago
Updated 8 February 2023, over 2 years ago

Problem/Motivation

The close button for dialog modals and popups is getting overridden somehow by the javascript library i believe. There are known issues about conflicts between bootstrap.js libraries, and jquery-ui.js libraries.

It should look like this:

<button type="button" class="ui-button ui-corner-all ui-widget ui-button-icon-only ui-dialog-titlebar-close" title="Close">
  <span class="ui-button-icon ui-icon ui-icon-closethick"></span>
  <span class="ui-button-icon-space"> </span>
  Close
</button>

But instead it looks like this:
<button type="button" class="ui-dialog-titlebar-close"></button>

Steps to reproduce

  • Open a dialog modal with the theme enabled and you will find no close button.
  • Go to the bootstrap4libraries.yml and remove dist/bootstrap/4.6.0/dist/js/bootstrap.bundle.js: { minified: true }, and it works.

Proposed resolution

Fix it, not sure how. I am guessing from the issue linked above it has something to do with how/ what order the libraries are loaded.

🐛 Bug report
Status

Active

Version

2.1

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • 🇷🇸Serbia vradova Krusevac

    Hello!

    I change the line in bootstrap4libraries.yml. I just add weight for the js library and the issue is gone on my dev site.

    I did patch locally...

  • 🇷🇸Serbia vradova Krusevac

    Git patch...

  • 🇮🇳India ravi kant Jaipur

    I just tried with the latest release and the issue did not replicate so I think it has been fixed in the latest release.
    Attaching a screenshot for confirmation.

  • Status changed to Closed: outdated about 1 month ago
Production build 0.71.5 2024