Drupal-check found some issues with Element\Fivestar which on manual inspection warranted further work.
1. In the getElementDescription() function the switch finishes with return for all cases, but the default case is not included, which resulted in a 'doesn't return array in all cases' error from the check. The fault was possible should the settings be bad, which is perfectly possible.
including a default case beside the 'none' case is sufficient.
2. userCanVote() sets entity_type and entity_id in a way for which the ?? operator was designed and is clearer.
Moved to #3226149: userCanVote(), getElementDescription(), process() need cleanup → :
The attached patch adds in the type hints and todo, and updates the expressions with ??. This is really meant as a starting point for discussion, though the type hints are useful in themselves.
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Re-rolled #8 against HEAD. Most of the fixes were handled in separate issues.
There are a few fixes left, which I cleaned up a bit.
I add it to the global issue #3377377 about drupal-check
Automatically closed - issue fixed for 2 weeks with no activity.