Provide UI for pattern conditions

Hi, I'm interested in that feature but trying to figure out how to add custom conditions from a custom module, as I need to add conditions based on my custom fields.

Do I have to follow some base class as in Rules module?

Hi @dtamajon you can create a class that extends ConditionPluginBase.
Have a look https://drupalsun.com/2021/04/29/condition-plugins-visibility-drupal-8-9 . Cheers

Thank you!

I tried to add conditions successfully (custom ones and default ones) but on saving a node the alias is generated without calling any 'evaluate' function from any Condition.

Am I missing something?

I had to fix a couple things to make it work on Drupal 10, but apart from that this feature seems to be working! @Berdir, could you comment on whether or not this feature should live in a submodule? That way we know how to move this forward. Since this feature has lived in this MR for two years already and it seems to be working great, I'm considering creating a new project for the submodule so that people can start using it.

Re-rolled patch 13 for Drupal 10

Patch #20 does not apply due to whitespace #21 applies

Adds a D10 session check and set for subrequest to patch 21

Fixes patch formatting issue for patch 23

Fix 'non-scalar value' error - patches 21-24

This is fantastic! Thanks for working on this. I may have time to contribute as well.

One change I think this needs is to disable the default, hard-coded conditions UI that pathauto already provides for specifying language and content type. I think that if this sub-module is used, then all conditions should be managed by it.

Please, let's keep all work in the merge request. The last three patch files are especially problematic because they don't include an interdiff.

[double post]

While this is working well, it exposes a problem with the PathautoWidget that sort of makes it useless with any conditions that rely on pulling data from the entity.

The form widget disables Pathauto if there isn't a matching pattern for the entity. The problem is that a pattern may not match an entity until the entity has been saved and has data.

Until now, the only conditions a pathauto pattern could have were entity bundle and language, both of which are known even before an entity is saved, so this wasn't a problem.

But now, with this, any type of condition can be added. For example, the Term Condition → module provides a condition plugin that evaluates if an entity has a specific term associated with it.

So, as a result, if you have a pattern with a "Page" content type condition and TermCondition for some taxonomy term "Term A", when you go to create a new Page node, the Pathauto checkbox won't be there and it won't be activated. If you save the node with a "Term A" reference, the pattern won't be activated. If you edit the node and save it again, it will be activated and the alias will be generated.

To be clear, the conditions UI that this patch provides is working as expected, it just exposes some additional challenges with Pathauto.

There seems to be an issue since the changes that were done in the past months: when updating an existing condition, it's being duplicated instead of the existing one being updated.

Hi folks!

Sorry for the beginner question but I don't have a huge amount of experience when it comes to anything more complicated than pulling in a patch.

With the release of the pre-crimbo commits do I need to manually roll a patch myself from the HEAD of this branch to get this feature D11 ready, or is there another way to do it?

Thanks for your patience!

You should click the "plain diff" link next to the merge request link (top of the issue on this page). It generates a git patch file. You should copy the contents of that into a plain text file in your project and include it with composer patches. Looks like it's already D11 compatible.

The thing holding up this issue is the lack of tests.