Labels no longer visible when 2.0.x release is used with SHS Webform because of visually-hidden class

Created on 22 July 2021, over 3 years ago
Updated 22 August 2024, 8 months ago

Problem/Motivation

The change in the 2.0.x branch for #2973580: Select lists do not have labels results in labels being hidden when using this module with https://www.drupal.org/project/webform_shs .

Steps to reproduce

  • Add a SHS field to a webform using labels for each level using 8.x-1.0-alpha5 release
  • Everything will work as expected
  • Upgrade to 2.0.x-dev release
  • Labels are no longer visible in form

Proposed resolution

Unsure. I opened 🐛 SHS 2.0.x compatiblity Active a few weeks ago to try to get some advice from the maintainers of that module since it seems like it should be fixed on that end, but haven't gotten a response.

I'm including a patch so that can be applied to SHS so the 2.0.x-dev branch can be used with webform_shs in case this helps someone else. I'm happy to put some time into fixing this, but I'm unsure what needs to happen on the webform_shs side to remain compatible with this change.

Any advice would be appreciated.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States kreynen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024