SHS 2.0.x compatiblity

Created on 29 June 2021, over 3 years ago
Updated 19 April 2023, over 1 year ago

Problem/Motivation

Drupal core added an unpublished state to taxonomy entities in 8.6. SHS added support for that in #3091724: Respect status for taxonomy terms on SHS widget(s) β†’

So far, the only issue I've run into with using the 8.x-1.x branch of this project with SHS 2.0.x is that the labels defined in the Webform UI for the Depth Labels aren't visible. I think that's because of the change in #2973580: Select lists do not have labels β†’

Output from 8.x-1.x ...

<label for="edit-degree-program-specialization-shs-0-0">Degree Level</label>

Output from 2.0.x...

<label id="edit-degree-program-specialization-shs-0-0-label" class="visually-hidden">Degree Level</label>

While I was able to get the labels back by removing the visually-hidden class in this change https://git.drupalcode.org/project/shs/-/commit/9dc7d2acf83815f547a8d57d..., that isn't a long term fix.

I don't completely understand how labels will be implemented when SHS is used on content entities, but removing this class will obviously impact that. Not sure what the best way to address this is, but I'm happy to put some time into a fix if you can point me in the right direction.

πŸ› Bug report
Status

Active

Version

2.0

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States kreynen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024