Uninstalling migrate_drupal_ui Does Not Remove Stored Migration Credentials From the Database

I verified that this is still an issue. But not quite for the reasons originally reported. The relevant state keys are created by the migrate_drupal module, not migrate_drupal_ui. It's natural that the state keys would still be in the database if migrate_drupal_ui is uninstalled and migrate_drupal is not. But migrate_drupal doesn't remove them either, which probably isn't a good thing for security. In any case, a module should clean up its stuff when being uninstalled.

It's easy enough to update the module to remove those state keys on uninstall and to create a test for it. But this issue suggests that there are sites out there with orphaned state keys. I have no idea how those should be handled. If there's a precedent, then let me know.

Since the Drupal migration modules are being removed for D12, then I think this issue should be handled before then. That way, anyone who still has migrate_drupal installed on their site will have the keys removed properly.

Seems pretty straight forward

Ran the test-only pipeline

1) Drupal\Tests\migrate_drupal\Kernel\MigrateDrupalUninstallTest::testUninstall
Failed asserting that Array &0 [
    'key' => 'upgrade',
    'database' => Array &1 [],
] is null.
/builds/issue/drupal-3224907/core/modules/migrate_drupal/tests/src/Kernel/MigrateDrupalUninstallTest.php:38

Which what would be expected.

LGTM