Incorrect numbers for footnotes

Confirming that this patch fixes this bug. When using this module with two paragraphs and 22 footnotes, they would be displayed 1 through 11 and then again 1 through 11. With this patch they are displayed 1 through 22.

Before

After

Adding a small fix that prevent a link in the footnote that would being replaced by (0).

@srdtw this should fix the (0) that are visible in your screenshot ;)

Thanks for the updated code, tostinni! I need this now and don't want to wait for the release, so I'm adding your changes as a patch. Looking forward to this excellent module as it develops! =o)

The footnote link is not always a number, it can be arbitrary text.
How does the patch handle this? Does overwrite the text with a number?

We could check if a value is automatically set fairly easily and add a class if so.

It gets more complicated when the content editor specifically sets the numbers to [1] [2] [3] etc, but I imagine we can ignore that edge case and cover that in documentation.

I am going to cover the automatic setting of the value case in ✨ Provide a JS alternative to the PHP-driven Footnotes Group like Footnotes All Block module Needs review and add credit to tostinni for the original patch + srdtwc for the thorough review time. Thanks!

Okay ✨ Provide a JS alternative to the PHP-driven Footnotes Group like Footnotes All Block module Needs review now fixes this in the Footnotes module + has automated testing coverage.

Thank you Scott.

Indeed when we implemented this, we hid the footnote number field as we thought it was confusing to the editor and let the system calculate the number. Then this patch made sense.

Thanks for the followup and the patch for ✨ Provide a JS alternative to the PHP-driven Footnotes Group like Footnotes All Block module Needs review

This module is now obsolete and is replaced by a similar block directly in the footnotes module (see ✨ All footnotes grouped in a block now available in Footnotes main module Needs review ).
If the new block has the same bug, you should open an issue there.