Do not initiate user entity storage in SiteConfigureForm

Created on 21 June 2021, over 3 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

We are working on fixing a Group module install problem from existing configuration by using the built-in config installer in this issue . This is complicated story but we managed to eliminate some Group specific issues but it seems there is also an issue in Drupal core. See comment #17 .

Steps to reproduce

// TODO Add a minimum code example.

Proposed resolution

Running drupal_flush_all_caches() before SiteConfigureForm.php#L326 solves the problem but we must not use this call because it is a peformance killer.
Speaking of performance... I remembered @Berdir's issue about Do not instantiate entity storages in constructors of services that do not always need them and it seems by only injecting the entity type manager and not the user storage, solves the issue.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1

Component
Install 

Last updated 4 days ago

No maintainer
Created by

🇭🇺Hungary mxr576 Hungary

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Production build 0.71.5 2024