Deleting any Trusted Browser deletes all

Created on 8 June 2021, almost 4 years ago
Updated 16 July 2023, almost 2 years ago

Problem/Motivation

  • on delete, the ID of the TB is obtained using str_replace function here
  • which is then fed into the delete method as is here
  • while the delete method validates if it is an integer here

Steps to reproduce

Set up several different trusted browsers, the try to delete one of them -> all will be deleted

Proposed resolution

Cast the value to int before passing it on.

Remaining tasks

Review the patch.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇷🇴Romania reszli Târgu Mureș

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024