- Merge request !2Issue #3217657: Allow developers to expose more configuration in the migrate form β (Merged) created by Matroskeen
- π¬π§United Kingdom welly
Having tested this recently, the changes made in the merge request work well and I'm able to expose additional config in the migrate form (I'm currently also overriding the MigrateSourceUi form class).
I've created a backport patch for RC1 (as that's the version I'm currently using) but happy to help out moving this ticket along. Is there anything specific that needs doing?
- π¬π§United Kingdom welly
Previous patch didn't apply for some reason. Let's try this one
- π¬π§United Kingdom welly
$options['update'] should be an int not a bool.
- π¬π§United Kingdom welly
Just to note I'm creating these patches so we can apply them as standard in our composer workflow :) Let me know how we can get this issue over the line and merged. This is a pretty important bit of work for a project! Cheers!
-
heddn β
committed 6167e75f on 8.x-1.x authored by
Matroskeen β
Issue #3217657 by welly, heddn, Matroskeen: Allow developers to expose...
-
heddn β
committed 6167e75f on 8.x-1.x authored by
Matroskeen β
- Status changed to Fixed
5 months ago 6:09pm 18 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- πΊπΈUnited States caesius
I have a migration that breaks after updating to the latest version of Migrate Source UI which I traced to this change. Does this update require updating configuration for old migrations?
What happens is that existing content gets overwritten exactly as intended by the source ID (here called
MatchKey
), however items new to an import do not get imported due to this error:Migration failed with source plugin exception: 'MatchKey' is defined as a source ID but has no value.
I believe removing the Migrate Source UI version of MigrateBatchExecutable causes the migrations to use the Migrate Tools version of the same class, which for whatever reason does not work with the code or configuration used for our migrations. We're using the latest version of Migrate Tools.
I looked through the release history and issue queue for Migrate Tools but couldn't find any indication of what updates need to be done.
I'll try to debug this more and may split off a new issue to the effect of "Document this breaking change" but wanted to flag this to the people who worked on this update.