Add a Simple Sitemap plugin for Monitoring

Created on 27 May 2021, almost 4 years ago
Updated 15 August 2023, over 1 year ago

Problem/Motivation

Add a Simple Sitemap plugin for Monitoring .

I'd appreciate to be able to see when Simple Sitemaps were generated via a Monitoring plugin, so Monitoring can report success/failure depending on thresholds. E.g if it has been a long time since a sitemap was last generated. This would help diagnosing if sitemap is failing silently.

Proposed resolution

A number plugin representing seconds since last run for each sitemap (currentTime - lastRun).

Thresholds are built into monitoring, so users can configure how many second is good/warning/error.

Sitemap last-creation dates can be found in {simple_sitemap} table.

Feature request
Status

Needs work

Version

4.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Merge request !75Add a Simple Sitemap plugin for Monitoring → (Closed) created by dpi
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Not currently mergeable.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    34 pass
  • Status changed to Needs review over 1 year ago
  • 🇦🇺Australia dpi Perth, Australia

    @gbyte I've reworked the 3.x MR to work with 4.x,
    Notes:

    • Added a new convenience method on the new Sitemap config entity. Ported date usage to new method.
    • Removed the sitemap metadata services from the v3 version, now that Sitemaps are config.
    • Functionality irt Monitoring remains the same as documented above.
    • Contains the same test coverage, reworked for 4.x compat
  • Pipeline finished with Success
    5 months ago
    Total: 362s
    #358819
  • 🇦🇺Australia dpi Perth, Australia

    4.2.2 merged in.

  • Pipeline finished with Failed
    5 months ago
    Total: 288s
    #358866
  • Pipeline finished with Success
    5 months ago
    Total: 306s
    #358864
  • Pipeline finished with Success
    5 months ago
    Total: 297s
    #358896
  • Pipeline finished with Failed
    5 months ago
    Total: 3690s
    #358865
  • 🇩🇪Germany gbyte Berlin
  • 🇩🇪Germany gbyte Berlin

    @WalkingDexter @dpi please check out the gitlab review. Let's not merge this before discussing if this should instead go into a 3rd party simple_sitemap_monitoring module which I feel should be the way to go ATM.

  • 🇷🇺Russia walkingdexter

    @WalkingDexter @dpi please check out the gitlab review. Let's not merge this before discussing if this should instead go into a 3rd party simple_sitemap_monitoring module which I feel should be the way to go ATM.

    I think this functionality can be added directly to the Monitoring module. It already contains plugins for other contrib modules.

  • 🇩🇪Germany gbyte Berlin

    @dpi Let us know if you think this issue should be reassigned to the monitoring module and the code moved into it or if this should go into a 3rd party module. Also please check out the points in the gitlab review.

  • Status changed to Closed: won't fix 2 months ago
  • 🇷🇺Russia walkingdexter

    Created an issue in the Monitoring module and adapted the proposed code. See New sensor: Simple XML Sitemap Active for further work.

Production build 0.71.5 2024