- πΊπΈUnited States attheshow
+1 for re-considering moving this to the database.
I'm new to using this module (great work, by the way!) but not new to Drupal at all. It seems a bit off-putting that every time I run a config export, the ik_constant_contact.tokens.yml file is show changes. It seems like if that's the case then this technically isn't configuration and more of a temporary content item that is constantly changing. I wonder if we could consider this an item that could simply live in the cache database table?
- Status changed to Active
over 1 year ago 6:28pm 4 May 2023 - πΊπΈUnited States rosemarystanley
Thanks! That's not a bad idea. I'll reopen this for consideration. (Updating the version as well)
- Status changed to Needs review
over 1 year ago 3:04pm 11 May 2023 - πΊπΈUnited States attheshow
Thanks so much for this! This is looking good in my initial testing!
- πΊπΈUnited States attheshow
One of the new updates appears to be failing when trying to update the site via drush. Here's the error I'm seeing:
Update failed: ik_constant_contact_update_93103 [error] Update aborted by: ik_constant_contact_update_93103
- πΊπΈUnited States rosemarystanley
Do you have any additional information via drupal logs?
- πΊπΈUnited States attheshow
I wasn't getting any useful info from Drush or dblog, so I ran the update in the browser. Here's what it shows there:
ik_constant_contact module Update #93103 Failed: Drupal\Core\Utility\UpdateException: There was an error running this update. in ik_constant_contact_update_93103() (line 137 of /app/web/modules/contrib/ik_constant_contact/ik_constant_contact.install).
- πΊπΈUnited States attheshow
One thing I see in update 93103 is it's checking for
$ccConfig['token_source'] === 'database'
and in my debugging it looks like$ccConfig['token_source']
is currently set toconfig
which would result in the exception taking place. - Status changed to Needs work
over 1 year ago 2:43pm 18 May 2023 - πΊπΈUnited States rosemarystanley
Thanks, that helps! I'll take a look as soon as I can. Moving back to needs work status.
- Status changed to Needs review
over 1 year ago 3:25pm 18 May 2023 - πΊπΈUnited States rosemarystanley
Ok rerolled the patch. Let's see how this does.
-
rosemarystanley β
committed aa1899fe on 3.x
Issue #3215168 by rosemarystanley: Move tokens to database instead of...
-
rosemarystanley β
committed aa1899fe on 3.x
- Status changed to Fixed
about 1 year ago 11:45am 23 October 2023 - Status changed to Fixed
about 1 year ago 11:48am 23 October 2023