- last update
over 1 year ago 13 pass - last update
over 1 year ago 13 pass - π¦πΊAustralia nicksanta
We've been running the patch from #7 in production for 2 years. Marking as RTBC.
- πΊπΈUnited States smustgrave
Seems related to β¨ Rename drupal messages Needs work but that doesn't mention the timeout. May be good to get this one in solo
- Status changed to Needs work
9 months ago 9:38am 23 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
This will result in the new message being untranslatable on sites that use it. For me the best solution here is for a site that needs this to use https://www.drupal.org/project/stringoverrides β
- Assigned to smustgrave
- πΊπΈUnited States smustgrave
Can try and update. Do seeing it's missing schema and a post_update hook. Is there anything else needed for it @alexpott?
- πΊπΈUnited States smustgrave
Actually @alexpott before diving into this want to make sure it's a change that will be accepted
Same would go for π [Move over credit] I feel the message of unlocking is strange RTBC and β¨ Rename drupal messages Needs work
Don't have a stake in this if you want to just advise people to use stringoverrides.
- π¬π§United Kingdom alexpott πͺπΊπ
Yeah I think we should be telling people to use that. Another option is to change the translatable text. But adding a layer of config in doesn't make sense to me.
- πΊπΈUnited States smustgrave
So when β¨ README file Needs review lands maybe we can repurpose this to update that README with the suggestion to use stringooverrides
.BTW thanks for pointing that one out.
Should the other two in #13 be closed as works as designed?
- Status changed to Closed: duplicate
9 months ago 2:47pm 26 March 2024 - πΊπΈUnited States smustgrave
Talking to @alexpott in slack and seems the desired approach is to use stringoverrides. So going to keep β¨ Rename drupal messages Needs work open about updating the existing text but a minimum in that ticket we can update the README with suggestion to the module stringoverrides.