Crop effect can be added to an image style with no crop type

Created on 19 May 2021, almost 4 years ago
Updated 10 December 2024, 5 months ago

Problem/Motivation

A crop effect can be added to an image style with no crop type set on it. This looks like it then leads to broken behaviour -- e.g. with Image Widget Crop, the crop part of the widget doesn't let me do anything.

Steps to reproduce

1. install the module
2. edit an image style
3. add the Manual Crop effect
-- because there is no crop type yet, the 'Crop type' dropdown in the form is empty
4. Save the effect and then the style.

Proposed resolution

It should not be possible to add a Manual Crop effect until there is at last one crop type, and the form should prevent that and explain what you need to do.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024