The FileUpdateService makes a call to file_move which has a default value of renaming the destination file if it already exists.
Meaning that subsequent calls to $plugin->updateUri($uri_new); would be referencing the existing file rather than the new (duplicate) one.
Attempt to rename a file to a name which already exists on disk. The updates will be applied against the existing file name, rather than the current destination.
For now, updated the logic to ensure that it makes sure to read and reference the file URI returned from file_move.
In a newer update, an option may be added to allow users to customize the behaviour.
e.g. skipping the file move if it already exists (updating references only), overwriting or renaming.
Provide a PR.
N/A
N/A
N/A
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Issue #3214405: Make use of the appropriate destination file
Automatically closed - issue fixed for 2 weeks with no activity.