Toolbar search input has aria-labeledby attribute without corresponding id

Created on 14 May 2021, about 4 years ago
Updated 20 April 2025, about 2 months ago

Problem/Motivation

I randomly saw that the toolbar search input has no corresponding id for labeling the input.

Steps to reproduce

activate admin_toolbar_search module and validate any page with toolbar.

Proposed resolution

add a label element, maybe visually hidden for screenreader support so there is no need for an explicit aria-labeledby

🐛 Bug report
Status

Closed: outdated

Version

2.4

Component

Code

Created by

🇩🇪Germany sunlix Wesel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇫🇷France dydave

    Could you please try with the latest version of the module?

    I have just tested this with admin_toolbar_search:3.5.3 and confirmed the search text field had an associated label tag which is indeed visually-hidden, as suggested in the issue summary 🟢, see:

    <div class="js-form-item form-item js-form-type-search form-type--search js-form-item- form-item-- form-item--no-label">
    
      <label for="admin-toolbar-search-input" class="form-item__label visually-hidden">Search</label>
      <input placeholder="Admin Toolbar quick search" accesskey="a" type="search" id="admin-toolbar-search-input" size="30" maxlength="128" class="form-search form-element form-element--type-search form-element--api-search ui-autocomplete-input" autocomplete="off">
    
    </div>
    

     
    Closing issue as outdated, for now.

    Thanks again for your help and contributions.

Production build 0.71.5 2024