Users with the administrator role are visible in certain places

Problem/Motivation

Users with the administrator role (e.g. user 1, but keeping in mind 📌 Add a container parameter that can remove the special behavior of UID#1 Fixed ) in Open Social are meant for development. Users that are visible in the community should have no roles with more permissions than site manager.

Currently if a user starts a mention (e.g. @a in a post) then the admin user is shown as well, this is confusing for users since the admin user shouldn't be used as active user on a production site.

Proposed resolution

As some sites in the wild may have adopted the admin user as a real user (or given the administrator role to real users) we must implement this in a backwards compatible manner. However, we can adopt the desired behaviour (of hiding the administrator user(s)) for new sites.

Introduce a new boolean setting hide_administrator_users in social_user. Set the default value in the social_user/config/install/social_user.settings.yml to true. In the update hook to introduce this value set it to false (to preserve current behaviour).

SocialProfileTrait::startQuery should be updated to check the newly introduced setting. If the setting is true then the query should join the user role table and exclude any users that have the role administrator (this can probably be best done with a leftJoin and the role included in the ON condition of the join so you do not have to deduplicate results, we're not interested in what other roles a user has).

Remaining tasks

• Add the new setting to the config schema for social_user
• Update social_user.settings.yml with new setting
• Create an update hook to introduce the config, preserving current behaviour
• Modify SocialProfileTrait::startQuery's behaviour depending on the setting
• Create a PHPUnit kernel test that verifies the behaviour of SocialProfileTrait based upon the setting

User interface changes

The admin user is no longer shown in mentions and other autocomplete systems on new site installs.

API changes

A new setting exists for extending functionality that can be used to check if the admin user should be hidden or not.

Data model changes