[D7] Don't trigger hook_file_download when no file is requested

Thanks for reporting this. I do not see any patch, so it seems like Active is the correct status (there is nothing to review).

I have backported the change from #3016814: Don't trigger hook_file_download when no file is requested → together with test changes.

Regular pipeline is green: https://git.drupalcode.org/project/drupal/-/pipelines/148353
Test only job is failing here: https://git.drupalcode.org/project/drupal/-/jobs/1343442

---- FileDownloadTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Browser    file.test         2647 FileDownloadTest->testPrivateFileTr
    Correctly returned 404 response for a private file url without a file
    specified.
Fail      Other      file.test         2649 FileDownloadTest->testPrivateFileTr
    Value array (
    ) is equal to value array (
      0 => 
      array (
        0 => 'private://',
      ),
    ).

Moving to Needs review.

Adding the tag for the final review.

This looks pretty good but I'm not sure about the assertions that reference an element on the return value of variable_get() - e.g.:

    $this->assertEqual($file->uri, variable_get('file_test_results', array())['download'][0][0]);

Perhaps it's safe to assume that the variable will always be set and that element will be present, but if we do something similar in isolation:

$ drush php
Psy Shell v0.9.12 (PHP 7.4.33 — cli) by Justin Hileman
>>> print_r(variable_get('file_test_results', array())['download'][0][0]);
PHP Notice:  Undefined index: download in phar:///usr/local/bin/drush8/vendor/composer/..eval()'d code on line 1

It may make the code more long-winded but can we avoid this?

Yes, I was on the edge when backporting these rows. Seems like we can use file_test_get_all_calls() to retrieve these results too, so I have updated the MR with this change. Hopefully now it is cleaner and safer. Thanks!

Tests are still green: https://git.drupalcode.org/project/drupal/-/pipelines/187591
And test-only job is still failing: https://git.drupalcode.org/project/drupal/-/jobs/1743067

Thanks - it's a bit circuitous but I think better to avoid potentially(/theoretically) referencing non-existent elements.

Automatically closed - issue fixed for 2 weeks with no activity.