- 🇭🇺Hungary danyg Budapest
Thanks, I tested the latest patch. It resolves the initial notice, I found some new with the latest patch:
Notice: Trying to access array offset on value of type null template_preprocess_tb_megamenu_item() függvényben (/app/sites/all/modules/tb_megamenu/tb_megamenu.themes.inc 86 sor).
Notice: Trying to access array offset on value of type null template_preprocess_tb_megamenu_subnav() függvényben (/app/sites/all/modules/tb_megamenu/tb_megamenu.themes.inc 296 sor).
Warning: array_multisort(): Array sizes are inconsistent tb_megamenu_insert_tb_item() függvényben (/app/sites/all/modules/tb_megamenu/tb_megamenu.functions.inc 441 sor).
I try to check these issues later, but now I set it "Needs work", since it doesn't seem perfect yet.
- Status changed to Needs review
almost 2 years ago 1:03pm 4 March 2023 - 🇭🇺Hungary danyg Budapest
Ok, I realized that the latest patch (diff) wasn't applied properly. I created a new patch from it and now it can be applied properly and fixes the notices that I mentioned before. So, it seems the changes in #7 are good, I had trouble only with the format. Actually, I would put it to RBTC since the logic looks good, but I change it to Needs Review again to have somebody test the patch.
- 🇨🇦Canada Nathan Tsai
#9 also applied successfully for me for " 7.x-1.0-rc6".
+1 for RTBC.
- Status changed to RTBC
about 1 year ago 1:46pm 27 September 2023 - 🇭🇺Hungary danyg Budapest
according to the last 3 comments, I changed to RBTC. Thanks for testing!