- First commit to issue fork.
- @codebymikey opened merge request.
- Status changed to Needs review
almost 2 years ago 1:58pm 9 February 2023 Attached a patch addressing the issue. The upstream core π Nested modals don't work: opening a modal from a modal closes the original Needs work issue only provides a fix if the modal is specifically called from the media_library modal.
However the issue is still present when called from a different modal e.g. Media Directories β 's
media_directories_ui
module.This patch ensures that we make use of a custom modal ID for the dialog so that there are no more conflicts regardless of what the calling modal is.
-
Mingsong β
committed 4776f964 on 2.x authored by
codebymikey β
Issue #3211487: Multiple Modals issues
-
Mingsong β
committed 4776f964 on 2.x authored by
codebymikey β
- Status changed to Fixed
almost 2 years ago 11:22pm 9 February 2023 - π¦πΊAustralia mingsong π¦πΊ
Thanks @Mikey.
Appreciate your great works as always.
- @codebymikey opened merge request.
- Status changed to Needs review
almost 2 years ago 2:20pm 13 February 2023 Forgot to address the modal dialog ID when resizing the modal on
ready.jstree
:treeContainer.on("ready.jstree", function(e, data) { data.instance.select_node(selectedNodes); // Make modal window height scaled automatically. $("#drupal-modal").dialog( "option", { height: 'auto' } ); });
It could be potentially replaced with something like:
treeContainer.closest('.ui-dialog-content').dialog( "option", { height: 'auto' } );
instead of:
$("#entity-reference-tree-modal").dialog( "option", { height: 'auto' } );
To be more flexible, but the static ID makes the code a lot more obvious.
Ensure that the nested modal is in focus once it's opened. This allows the Escape key to work on the correct modal when pressed.
-
Mingsong β
committed 12398432 on 2.x authored by
codebymikey β
Issue #3211487: Multiple Modals issues - Use appropriate modal ID for...
-
Mingsong β
committed 12398432 on 2.x authored by
codebymikey β
- Status changed to Fixed
almost 2 years ago 5:07am 14 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.