Remove the "none selected" behavior from the address validation settings

Created on 23 April 2021, almost 4 years ago
Updated 21 February 2025, 13 days ago

Address validation currently features checkboxes to pick which countries address validation should apply to:

However, if you select none, then it applies address validation to both. I don't see why it should do this ... there are only two options, and it's simply much clearer to treat checkboxes as enabled when checked and disabled when not. We should remove the "none" behavior, which will mean an update hook to check both countries in instances where neither are currently checked.

πŸ“Œ Task
Status

Active

Version

1.0

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States rhovland Oregon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States rszrama

    I reviewed this this evening, and perhaps it didn't work before, but it works now. That said, it's a weird place to use this sort of "selecting none applies to all" behavior. There are only two countries, and it should just be treated as enabling. I'm going to convert this to a task to remove this "none" behavior, but it will require an update hook to convert any configuration with none selected to have both selected. For that, I think we can reserve the change for a new major version.

Production build 0.71.5 2024