- πΊπΈUnited States codechefmarc
I've tested your fix, seanB, and that appears to work for me. I'm going to do some additional testing before I put in a PR over on GitHub where we manage this module. Thanks for submitting the bug and the fix. I'll post again when the PR is ready for review.
- Status changed to Needs review
11 months ago 8:12pm 11 January 2024 - πΊπΈUnited States codechefmarc
I've added your fix (from the other d.o. issue), @seanB, to the PR over on GitHub (https://github.com/emulsify-ds/emulsify_twig/pull/61) that should address these three Drupal.org issues:
https://www.drupal.org/project/emulsify_twig/issues/3160391 π Check if 'attributes' index is set in bem context Needs review
https://www.drupal.org/project/emulsify_twig/issues/3210140 π Error offsetExists() when i use 'twig_render_template' function Needs work
https://www.drupal.org/project/emulsify_twig/issues/3302662 π PHP error on passing array in attributes variable with add_attributes() Needs workIf someone can review it and let me know if that works, I'll merge that in. Thanks!
- Status changed to Fixed
7 months ago 10:56pm 2 May 2024 - πΊπΈUnited States codechefmarc
This has now been fixed as part of 5.0.0.
Automatically closed - issue fixed for 2 weeks with no activity.