Pager does not follow the request stack

Created on 15 April 2021, about 4 years ago
Updated 16 May 2025, 18 days ago

Problem/Motivation

  1. Some code calls PagerManager::createPager normally
  2. Some time later a new request gets pushed on the request stack
  3. Another call to PagerManager::createPager
  4. The new request gets popped from the request stack
  5. The pager now correlates with the already gone subrequest

Steps to reproduce

https://drupal.stackexchange.com/a/302336/69441

Proposed resolution

  1. PagerParameters needs to be able to return the current request
  2. PagerManager::createPager should use SplObjectStorage for the $pagers property where each request maps to the current page array

Remaining tasks

Agree, patch, test, commit.

User interface changes

None.

API changes

https://www.drupal.org/project/pagerer β†’ breaks. I do not know how to handle that.

Data model changes

Release notes snippet

πŸ› Bug report
Status

Active

Version

11.0 πŸ”₯

Component

base system

Created by

πŸ‡¨πŸ‡¦Canada Charlie ChX Negyesi 🍁Canada

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024