- 🇳🇴Norway zaporylie
IMHO it would make more sense to check whether payment was created from the payment method than to check for a completed order in this case.
That being said, not sure if this should be addressed as a feature request. I am convinced this could be considered a bug for Commerce Recurring. I think an unreusable payment method should not be set on Subscription. One should probably set conditions on payment gateways to avoid situation like this but the
Drupal\commerce_recurring\EventSubscriber\OrderSubscriber::onPlace()
should still check and prevent setting payment method that is non reusable on the subscripion. - Merge request !37Issue #3208403 by zaporylie, Jeff Veit: Don't set non-reusable payment method on Subscription in onPlace event → (Merged) created by Unnamed author
- Status changed to Needs review
8 months ago 4:26pm 14 August 2024 - Status changed to Fixed
8 months ago 1:41pm 15 August 2024 -
jsacksick →
committed a77d2ab9 on 8.x-1.x authored by
zaporylie →
Issue #3208403 by zaporylie, Jeff Veit: Don't set non-reusable payment...
-
jsacksick →
committed a77d2ab9 on 8.x-1.x authored by
zaporylie →
Automatically closed - issue fixed for 2 weeks with no activity.