When jquery-ui-slider-pips is installed via composer.json, the css and js paths change

Created on 12 April 2021, over 4 years ago
Updated 21 June 2024, about 1 year ago

Problem/Motivation

For facets_range_widget, it's good to be able to specify libraries such as jquery-ui-slider-pips via composer.json, but the paths recommended in README.txt no longer apply.
e.g. jquery-ui-slider-pips/dist/jquery-ui-slider-pips.min.js is now jquery-ui-slider-pips/dist/js/jquery-ui-slider-pips.js (unminified) and jquery-ui-slider-pips/dist/jquery-ui-slider-pips.min.css is now jquery-ui-slider-pips/dist/css/jquery-ui-slider-pips.min.css.

Proposed resolution

Add jquery-ui-slider-pips via composer.json, e.g.

        {
            "type": "package",
            "package": {
                "name": "simeydotme/jquery-ui-slider-pips",
                "version": "1.11.3",
                "type": "drupal-library",
                "source": {
                    "url": "https://github.com/simeydotme/jquery-ui-slider-pips",
                    "type": "git",
                    "reference": "origin/gh-pages"
                }
            }
        }

Apply patch to alter paths in facets_range_widget.libraries.yml

Remaining tasks

Alter README.txt?

Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇳🇿New Zealand jonathan_hunt

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇹Italy p4trizio Como

    I confirm the issue

  • The reference does not seem to be good, by using the recommended tag version (v1.11.3) there is no issue and no need a patch :

    1. First, add this in repositories part in composer.json :

      "jquery-ui-slider-pips": {
          "type": "package",
          "package": {
              "name": "simeydotme/jquery-ui-slider-pips",
              "version": "1.11.3",
              "type": "drupal-library",
              "source": {
                  "url": "https://github.com/simeydotme/jquery-ui-slider-pips",
                  "type": "git",
                  "reference": "v1.11.3"
              }
          }
      }
      
    2. And then execute :

      composer require simeydotme/jquery-ui-slider-pips
      
Production build 0.71.5 2024