- Status changed to Closed: duplicate
5 months ago 9:37am 25 August 2024 - π¨πSwitzerland berdir Switzerland
Just committed π Error when deleting orphaned flags Fixed instead.
When deleting a flag that is associated with a flaggable that no longer exists, FlagCountManager will try and pass a NULL item into resetLoadedCounts, which is rejected as a TypeError.
Not sure how this cropped up, although I expect it can be reproduced like this:
Create a content type
Create a flag that can be used to flag the content type
Create a content item of the new tyoe
Flag the content item
Delete the content item
Delete the flagging in code; load the flag, call ->delete() on it
Check whether the flaggable still exists before passing it into resetLoadedCounts().
Create MR
Review
Commit
None
None
None
Closed: duplicate
Flag core
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Just committed π Error when deleting orphaned flags Fixed instead.