Allow disallowed_operations to be altered/extended

Created on 18 March 2021, over 3 years ago
Updated 7 July 2023, 12 months ago

Problem/Motivation

We have some custom forms on a node.
This always triggers the code to add the "Rabbit hole" settings which aren't needed there.

This patch allows to alter the $disallowed_operations variable.

Steps to reproduce

Add a custom form to a node.

Proposed resolution

Allow $disallowed_operations to be alterable

Remaining tasks

Review patch

✨ Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium Mschudders

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¬πŸ‡§United Kingdom james.williams

    I totally agree something is needed here. Using hook_entity_extra_field_info() could be a way to help with this - whether in combination with this proposed hook_rabbit_hole_disallowed_operations_alter() hook, or instead of it.

  • Status changed to RTBC 12 months ago
  • πŸ‡¬πŸ‡§United Kingdom james.williams

    Even so - the patch works quite well enough for my needs, even if doesn't allow for the easy configurability for non-coders that hook_entity_extra_field_info() would.

    Setting to RTBC as the patch works well and is a worthwhile improvement over not having it. Further work could always be done in a follow-up if really wanted to make it more easily configurable.

  • πŸ‡ΊπŸ‡¦Ukraine Matroskeen πŸ‡ΊπŸ‡¦ Ukraine, Lutsk

    @james.williams I appreciate your feedback, but I must mention that 8.x-1.x won't include new features. I'll make sure it's described on the module page.

    In the meantime, feel free to take some time and test a new 2.0.0 version that should not have this issue.
    Here is a change record with all major changes in 2.0.x: https://www.drupal.org/node/3359194 β†’

  • Status changed to Needs review 12 months ago
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 12 months ago
    21 pass
  • πŸ‡¬πŸ‡§United Kingdom james.williams

    Fair enough :) Here's a rerolled patch for 2.0.x then, though it will need someone else to review & test now.

Production build 0.69.0 2024