ScopeClosingBraceSniff - Fatal error: str_repeat(): Second argument has to be greater than or equal to 0

"name": "drupal/coder", "version": "8.3.12", "source": { "type": "git", "url": "https://git.drupalcode.org/project/coder.git", "reference": "719ddb16aec2e5da4ce274bf3bf8450caef564d4" },

PHP Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: str_repeat(): Second argument has to be greater than or equal to 0 in /var/www/html/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ScopeClosingBraceSniff.php on line 185 in /var/www/html/vendor/squizlabs/php_codesniffer/src/Runner.php:606 Stack trace: #0 [internal function]: PHP_CodeSniffer\Runner->handleErrors(2, 'str_repeat(): S...', '/var/www/html/v...', 185, Array) #1 /var/www/html/vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ScopeClosingBraceSniff.php(185): str_repeat(' ', -1) #2 /var/www/html/vendor/squizlabs/php_codesniffer/src/Files/File.php(496): Drupal\Sniffs\WhiteSpace\ScopeClosingBraceSniff->process(Object(PHP_CodeSniffer\Files\LocalFile), 15) #3 /var/www/html/vendor/squizlabs/php_codesniffer/src/Files/LocalFile.php(91): PHP_CodeSniffer\Files\File->process() #4 /var/www/html/vendor/squizlabs/php_codesniffer/src/Fixer.php(174): PHP_CodeSniffer\Files\LocalFile->process() #5 /var/www/html/vendor/squizlabs/php_codesniffer/ in /var/www/html/vendor/squizlabs/php_codesniffer/src/Runner.php on line 606

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 11 months ago →
🇺🇸United States DamienMcKenna NH, USA
Just ran into this running the latest phpcs 3.9.2 against the Views codebase.
Comment 11 months ago →
🇺🇸United States DamienMcKenna NH, USA
I created a PR of JamesDevware's code: https://github.com/pfrenssen/coder/pull/228
Status changed to RTBC 11 months ago11:09am 2 May 2024
Comment 11 months ago →
🇺🇸United States DamienMcKenna NH, USA
I can confirm that the patch fixes the problem for me with Views.
Status changed to Needs work 11 months ago11:31am 2 May 2024
Comment 11 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
thanks, the next step is to add a test case so that we can confirm that we are actually fixing something.

Can you add that to your PR?

Comment 11 months ago →

System Message

klausi → authored 10a7be4b on 8.3.x

fix(ScopeClosingBrace): Exclude sniff from PHP template files and fix...

Status changed to Fixed 11 months ago11:42am 5 May 2024
Comment 11 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
I looked into this and noticed that this was already fixed upstream, so I synced our sniff from PHPCS.

I also disabled the ScopeClosingBraceSniff for template files - it does not make sense to run them on templates, since the braces follow the HTML indentation there.

I added a test case to demonstrate that there is no error, not perfect as the sniff is now disabled for templates, but good enough.

Then I found some interesting behavior in Drupal core with multi-line function declarations, improved our handling to allow empty "{}" function bodies.

Merged https://github.com/pfrenssen/coder/pull/229 .
Comment 11 months ago →
solideogloria
Nice. I've tried empty function bodies in that format before.
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.