- π§πͺBelgium herved
I noticed π Make BaseFieldOverride inherit internal property from the base field Fixed fixed
isInternal()
forBaseFieldOverride
in core 10.1.6
I believe it should address point 1 but not point 2 (from #9).
Is my assumption correct in the first place? that we want to skip internal and read-only fields but not computed - Status changed to Needs work
7 months ago 10:33pm 23 August 2024 - π¨πSwitzerland berdir Switzerland
removing the revision affected field seems sensible, that is calculated on save anyway. Should be updated to a merge request to verify that tests still pass.
- π§πͺBelgium herved
The IS is no longer accurate since π Make BaseFieldOverride inherit internal property from the base field Fixed fixed
isInternal
forBaseFieldOverride
and path aliases are now exported.
But maybe we could use this issue to discard fields that are marked as read-only?
I created a MR, anyway. - π¬π§United Kingdom alexpott πͺπΊπ
This is a great fix. Lots of hardcoded overrides removed and works a treat. I'm using this MR on a site with exported commerce products & variations and it cleans up a load of stuff.