- Status changed to Needs review
about 1 year ago 7:38pm 21 November 2023 - Status changed to Needs work
5 months ago 3:11pm 5 September 2024 - πΊπΈUnited States smustgrave
Actually since I added configuration validation in 3.0.x branch is this still needed?
- Merge request !6Issue #3201950 by koztunc, jacobbell84, stomusic, smustgrave: Implement custom... β (Open) created by smustgrave
- Status changed to Needs review
5 months ago 3:55pm 5 September 2024 - πΊπΈUnited States smustgrave
Take my previous statement back. I've updated slightly for 10.3
Will need a review from someone else besides myself.
- π§πΎBelarus pavel.bulat
pavel.bulat β made their first commit to this issueβs fork.
- π§πΎBelarus pavel.bulat
The patch had an issue:
Error: Call to undefined method Drupal\Core\Field\BaseFieldDefinition::id() in limited_field_widgets_field_widget_third_party_settings_form() when you try to open the `Manage Form Display` tab with fields that were created on a code level.
For example: a Commerce Order has an Unlimited Order Items field. The field definition for the Order Items doesn't have id().Steps to reproduce
1) Install Drupal Commerce and Commerce Order
2) Create a new order type
3) Open Manage Form Display tabIn the last commit, I added a check
if ($field_definition instanceof FieldConfigInterface)
. It fixed the issue, but I am not sure that it was the right way to fix it, so feel free to review it.