Share via Email

Hi, @balis_m! Nice catch and improvement proposal!
At first sight seems like your patch lacks an update function, so there would be no need to reenable the module to apply this functionality.

Will work on it and create a merge request.

Created MR with @balim_s patch and a few updates:
- changed elements order;
- created update function;
- made mailto links open in a new tab.

Can any maintainer review this issue?

@paulrad, I've Tested the shared MR- MR !9 mergeable on Drupal Version- 9.5.11, sharing below testing steps i have followed & testing results-

Testing Steps:

Set up a Drupal 9.5
Enable/Install the Share Everywhere module
Create a new content type (For the content which have Share Everywhere enabled)
View node- for before patch results (Attached before result)
Download the shared patch & apply.
Go back to the created content node and re-verify this.

Testing Results:
After applying the patch, the share Email icon was added now, but when I clicked on it, no action was performed. Also, some of the Share icons were not working for me even before applying the patch (Only Facebook, Twitter & LinkedIn were working) attached after result.

Thanks for your work, @Sandeep_k!
I've retested it locally and can confirm that it still works as designed for me (screenshots added).
I guess the issue with it was caused by the fact that you've added the patch and hook_update_N didn't work out this way.
Also issues with other parts of functionality isn't reproducible on my side.

Hi @paulrad, Thanks for the details. I have retested this. The other icons are working for me now but while applying this MR- MR !9 mergeable I am getting this error (Patch error attached), not sure if this is due to the patch I have already allied for this issue- https://www.drupal.org/project/share_everywhere/issues/3417029 🐛 Share icons animation not working RTBC