See #3162827: Do not instantiate entity storages in constructors of services that do not always need them → for background.
Instantiating an entity storage handler is expensive. It should not be injected into other classes; instead, inject the entity type manager and get the storage when needed.
This should be documented where developers are likely to see it:
- the entity storage interface
- the entity storage base class
- EntityTypeManagerInterface::getStorage()
Needs work
11.0 🔥
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I think we should add a PHPStan rule, @mglaman said here https://drupal.slack.com/archives/C1BMUQ9U6/p1702293217715539 that is feasible. I'm not sure I have enough skills for this. I've opened https://github.com/mglaman/phpstan-drupal/issues/686