- Issue was unassigned.
- Status changed to Postponed
9 months ago 5:35am 8 August 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Postponed on ๐ Fix โriskyโ tests Fixed
- Assigned to mondrake
- Status changed to Active
9 months ago 12:52pm 12 August 2024 - Issue was unassigned.
- Status changed to Needs review
9 months ago 9:47pm 12 August 2024 - Status changed to RTBC
9 months ago 3:05pm 13 August 2024 - ๐บ๐ธUnited States smustgrave
Refactor seems fine, accomplishes the task without breaking anything
- Status changed to Needs review
9 months ago 4:06pm 13 August 2024 - ๐ฌ๐งUnited Kingdom longwave UK
Is it not simpler just to do this to explicitly test the
tearDown()
method, and avoid this code running on all other teardowns in this class?- protected function tearDown(): void { + public function testTearDown(): void { parent::tearDown();
- Status changed to RTBC
9 months ago 4:20pm 13 August 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Uhm we shouldnโt call tearDown() from a test directly IMHO. The tear down process involves the framework calling methods marked with
PostCondition
andAfter
attributes - tearDown is just โoneโ of such methods nowadays. -
longwave โ
committed d38aac15 on 11.x
Issue #3196507 by mondrake, longwave, mxr576, alexpott:...
-
longwave โ
committed d38aac15 on 11.x
- Status changed to Fixed
9 months ago 9:11pm 13 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.