- 🇮🇹Italy itamair
Hi here ... is this still valid/relevant?
Should we merge/commit #24 this into 8.x-3.x-dev?
I am not going to (cannot) test the Ludwig integration ... so I would need a RTBC by someone that did it. - last update
over 1 year ago 4 pass - 🇭🇷Croatia devad
Multiple library versions are updated to the latest releases.
If we are going to commit this soon it's better to have the latest versions inside the ludwig.json file.
- 🇮🇹Italy itamair
Ok nice. So is the #29 patch RTBC and ready to be committed into code base?
- 🇭🇷Croatia devad
So is the #29 patch RTBC and ready to be committed into code base?
It's ready as far as I am concerned. However, I am the author of the patch and by Drupal rules I should not be the one to declare it as RTBC also.
I suppose we can declare it as RTBC due to community comments #14, #17 and #19 which were reviews of very similar patches before. But it's up to you to decide if you want to commit it now or wait for more community reviews. :)
- Status changed to Fixed
over 1 year ago 11:11pm 26 April 2023 - 🇮🇹Italy itamair
Ok, adde this on both 8.x-3.x-dev and 8.x-4.x-dev branches
Automatically closed - issue fixed for 2 weeks with no activity.